search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
863 stars 125 forks source link

Missing `onFocus` #204

Closed phungleson closed 1 year ago

phungleson commented 1 year ago

A recent commit seems to remove onFocus from type definition.

https://github.com/ryansolid/dom-expressions/commit/5d0b08317f0136670e3dfb9e76c9a24a20b24de1#diff-b30b26e449710cd6cdd9f82724a2ca1ac009365d41734e30b0f46a7b8aae6492L113

Let me know if I can help to add it back.

Cheers,

ryansolid commented 1 year ago

I think it is still there just moved.

phungleson commented 1 year ago

Yeah thanks, someone on Discord also pointed out.

In that case, I am not sure why my vscode didn't auto-suggest it? maybe vscode can only detect first level interface?

image
phungleson commented 1 year ago

Err, I removed node_modules and install again, and it seems to work.

Cheers,