search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
863 stars 125 forks source link

bug: custom element readonly prop always converted to readOnly #212

Closed MarkChrisLevy closed 1 year ago

MarkChrisLevy commented 1 year ago

Related to https://github.com/solidjs/solid/issues/594 - basically you cannot have a custom element with readonly prop, as it is always converted to readOnly, which is required for input element, but readOnly is not part of HTMLElement spec, only HTMLInputElement.

https://playground.solidjs.com/anonymous/3385e30a-71ab-478f-8307-4752b1729eee

Aliasing readonly to readOnly should be made only for tag.

ryansolid commented 1 year ago

I hear you. Right now all aliases are global so would take some rework

MarkChrisLevy commented 1 year ago

I can make a PR, including changes related to #211.

MarkChrisLevy commented 1 year ago

Fixed with #213