search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
863 stars 125 forks source link

Supported non-standard input attributes #225

Closed elite174 closed 1 year ago

elite174 commented 1 year ago

Referring to this issue https://github.com/solidjs/solid/issues/1642 I added non-standard attributes (see this https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search#non-standard_attributes).

ryansolid commented 1 year ago

Thanks

jesseb34r commented 1 year ago

I'm definitely happy to have the non-standard search attributes added. If we are going to add these, should we add all of the non-standard input attributes? mdn reference

You added autocorrect, incremental, and results. There is also autocapitalize, orient, and webkitdirectory. I don't know how useful they are to have on the type but they are valid attributes.

elite174 commented 1 year ago

@jesseb34r thank you! I guess I missed them. Will make a PR today!