search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
858 stars 125 forks source link

add heading tags to const DOMElements #246

Closed bigmistqke closed 1 year ago

bigmistqke commented 1 year ago

As mentioned here heading tags are currently not included in DOMElements. This pr adds h1-h6 to the constant.

nksaraf commented 1 year ago

Looks good to me. My bad on missing those!

bigmistqke commented 1 year ago

Lovely :-)

I probably should have checked if there were other valid html-elements missing in the list. It's a bit tricky since valid html-tags are a bit of a moving target, and maybe it shouldn't be the responsibility of dom-expression to keep track of the spec? There is a package called [html-tags](https://www.npmjs.com/package/html-tags] which we could depend on to do this work for us.