updates `draggable` attribute to allow `"true"

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering

MIT License

858 stars 125 forks source link

updates `draggable` attribute to allow `"true" | "false"` #249

Closed titoBouzout closed 1 year ago

titoBouzout commented 1 year ago

draggable="false" was giving me a typescript error on the JSX of the editor.

I have a question, all the booleans used on attributes on this file can be updated to be boolean | "true" | "false" right? (besides any other allowed value). If so, I can take a look to update them all.

Playground: https://playground.solidjs.com/anonymous/49b94a9e-7896-4ea3-9853-fddad75e65e9

ryansolid commented 1 year ago

The psuedo-booleans like this should have string "true"/"false" allowed. But not all booleans. Just the ones like draggable that take strings I believe. We should actually make sure "false" does what we thing it does in a context that can't be compiled optimized out. Typical boolean attributes that are always true if present shouldn't allow for this though.