search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
858 stars 125 forks source link

Comments out transformation of `this` #256

Closed titoBouzout closed 11 months ago

titoBouzout commented 1 year ago

Related to https://github.com/ryansolid/dom-expressions/issues/247

It comments out the transformation of this to $self as its breaking function binding in solid. Presumably the transformation is for compatibility with mobx-jsx which I guess is barely used compared to solid.

ryansolid commented 1 year ago

Not sure what to do with this one. It's a bit of tug of war. It originally came about because of people doing web components with Solid. I have basically no use for this at all but it was causing issues for people.