ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
858 stars 125 forks source link

Incorrect TypeScript definition for `http-equiv` and `accept-charset` attributes #260

Closed yume-chan closed 1 year ago

yume-chan commented 1 year ago

The http-equiv attribute on <meta> element (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#http-equiv) and accept-charset attribute on <form> element (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#accept-charset) are the only two exceptions in all HTML attributes that they use kebab case.

dom-expression (and Solid) doesn't have any special handing for them (as opposite to React who accepts camelCase but emits kebab case), but the TypeScript definition for these two attributes are in camelCase and lower case:

https://github.com/ryansolid/dom-expressions/blob/a85d688353fef165b0456d5e192f4359dc00d5cb/packages/dom-expressions/src/jsx.d.ts#L989-L995

https://github.com/ryansolid/dom-expressions/blob/a85d688353fef165b0456d5e192f4359dc00d5cb/packages/dom-expressions/src/jsx.d.ts#L841-L853