search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
858 stars 125 forks source link

ReferenceError: ogComplete is not defined #265

Closed nksaraf closed 1 year ago

nksaraf commented 1 year ago

Looks like ogComplete has not been declared before use here. Also might be a hint that we are not testing the streaming anywhere.

https://github.com/ryansolid/dom-expressions/blob/a85d688353fef165b0456d5e192f4359dc00d5cb/packages/dom-expressions/src/server.js#L201C14-L201C14

ryansolid commented 1 year ago

This only impacts the render async flow. But yeah it wouldn't crash (outside of strict mode) but it would pollute the global namespace.