ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
874 stars 125 forks source link

Treat `inert` as a boolean attribute #281

Closed macarie closed 10 months ago

macarie commented 11 months ago

I found this little issue while using SolidJS. I hope this is the right package to report the bug on.

inert should behave like disabled, hidden, and other boolean attributes, but it's rendered as inert="true" or inert="false" (which makes the element inert).

SolidJS Playground.

Would it be enough to add "inert" to this list? If so, I can open a PR 😄

https://github.com/ryansolid/dom-expressions/blob/51b297d6ed45d1a3dbbe7a45f2f58b8b524427ab/packages/dom-expressions/src/constants.js#L1-L26