search

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
863 stars 125 forks source link

ssr render generated script is missing`;` #344

Closed thinke5 closed 5 days ago

thinke5 commented 2 weeks ago

When ssr renders html, it generates this code

<script>self.$R=self.$R||[];_$HY.r["0200001000001000001100"]="$$f"_$HY.r["02000010000010000020"]="$$f"</script>

The generated code is missing; it will cause the generated code to execute incorrectly https://github.com/ryansolid/dom-expressions/blob/b0016751ad0149e61c93337ce10c135f3f8efe90/packages/dom-expressions/src/server.js#L20

ryansolid commented 1 week ago

Yeah renderToStringAsync/Stream has it but it is missing from renderToString. Good find.