search

ryanspletzer / ServiceBusForWindowsServerDsc

***NOTE Service Bus for Windows Server is a retired product and this is no longer maintained.*** The ServiceBusForWindowsServerDsc PowerShell module provides DSC resources that can be used to deploy and manage a Service Bus for Windows Server farm.
MIT License
4 stars 2 forks source link

Refactor Tests to meet DSC Resource Testing Guidelines #15

Open ryanspletzer opened 7 years ago

ryanspletzer commented 7 years ago

https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md

ryanspletzer commented 7 years ago

The unit tests themselves are now using the common DSCResource.Tests meta tests as well as the unit test template, but they need to be reorganized and there also need to be more, finer-grained unit tests for better coverage.

johlju commented 7 years ago

@ryanspletzer I have change the DscResource.Tests to have a parameter ResourceType that can be set to 'Class'. I have not PR that in yet, since I would like to know that it works. Do you have an opportunity to test this?

Read about it here: https://github.com/PowerShell/xSQLServer/issues/673#issuecomment-314169764

ryanspletzer commented 7 years ago

Hey @johlju thanks for working on that, I will try to get around to it at some point. TBH I have fallen off with maintaining this repo because Service Bus for Windows Server is being discontinued after this current version... But I understand that folks in the SharePoint space would still like something like this to be able to facilitate setting up Workflow Manager (which also seems like Workflow Manager is also getting discontinued because it has a dependency on Service Bus for Windows Server...).

johlju commented 7 years ago

Ah I see. That unfortunate that it's being discontinued when you put so much work in this :/

I can fork this repo and test it myself, I just thought you had better knowledge of this repo so I would go faster. :smile: It could be a good test since you already using the templates and have class based resources.

johlju commented 7 years ago

The change to DscResources.Tests was merged today so if you'd like you can change your tests so that you don't need the workaround :smile:

ryanspletzer commented 7 years ago

@johlju Nice! I'm about to be traveling for work for a few days but hopefully I can dust this thing off and swing back around to it...