ryanspletzer / ServiceBusForWindowsServerDsc

***NOTE Service Bus for Windows Server is a retired product and this is no longer maintained.*** The ServiceBusForWindowsServerDsc PowerShell module provides DSC resources that can be used to deploy and manage a Service Bus for Windows Server farm.
MIT License
4 stars 2 forks source link

Fixed nested modules import #37

Open spawluk opened 7 years ago

spawluk commented 7 years ago

When I defined custom database names I got error that New-SqlConnectionString cmdlet is not found.

spawluk commented 7 years ago

My PR unfortunately did not fixed issue with CommandNotFoundExecption

ryanspletzer commented 7 years ago

Thanks for taking a crack at it, I've been a little swamped lately... These things are tricky to nail down. Part of me wishes I'd stuck with non class-based resources, but I'm determined to make it work!

spawluk commented 7 years ago

I can confirm that some parts of it works on Windows Server 2016.

I'm little surprised of your determination, because even MS stuck to MOF based resources.

Maybe they know that class based resources are hard to debug and maintain? ;)

ryanspletzer commented 7 years ago

Well from what I understand... it's because they started with the classic approach for certain products so in order to not severely "shake up" those repo's and maintain compatibility they've continued with the same approach. They'd probably have to increment a major version number to start over with a class-based approach for things like Exchange, SharePoint etc... which would be a lot of work + disruption.

I drank the Kool-Aid when I watched Helmick's + Snover's DSC classes on MVA and they were saying class-based was the future, so I went that route. :)

Funny enough, Service Bus for Windows Server and Workflow Manager (which I understand because they're sort of deprecated?) and BizTalk Server are the few MSFT products I haven't seen DSC resources for from them... Most of the rest of their products have a DSC offering from Microsoft.

spawluk commented 7 years ago

Finally i managed to fix Set, Get and Test methods. I can tomorrow verify on fresh server if all resources are working as expected

ryanspletzer commented 7 years ago

Greatly appreciate your efforts!