ryansuitposungkono / openjs-grid

Automatically exported from code.google.com/p/openjs-grid
0 stars 0 forks source link

Grid reloads without confirmation when an action that would cause a grid reload occurs even when changes are pending. #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Edit a row
2. Accidentally click the column header that sorts.
3. Edits are lost.

What is the expected output? What do you see instead?
So the issue is when you invoke an action when there is a save pending.  In my 
case, I was doing data entry and I had an issue of mouse-brain fail, where I 
clicked on the sort row on accident.  Instead of rearranging the rows client 
side and maintaining the dirty state, it reloaded the data in the table and 
flushed my changes with nary a warning.

A better way of handling this would be making sure that operations that invoke 
a $grid->load() of some sort will pass through a callback or preset 
alert/confirm if there are pending changes that might require a save that will 
be lost otherwise.

What version of the product are you using? On what operating system?
1.6
Mac OSX
Safari latest build.

Please provide any additional information below.
Great stuff, hopefully this feedback is viewed as a positive.

Original issue reported on code.google.com by vep....@gmail.com on 12 Apr 2011 at 5:26

GoogleCodeExporter commented 9 years ago
Ill add a flag for confirmBeforeReload

Original comment by Seancla...@gmail.com on 19 Apr 2011 at 5:01

GoogleCodeExporter commented 9 years ago

Original comment by Seancla...@gmail.com on 5 Jul 2011 at 5:10

GoogleCodeExporter commented 9 years ago

Original comment by Seancla...@gmail.com on 20 Jul 2011 at 3:16