ryansurf / cli-surf

Get surf and ocean data from the command line interface
MIT License
18 stars 30 forks source link

matplotlib v 3.9.0 only #119

Closed ryansurf closed 3 months ago

ryansurf commented 3 months ago

https://github.com/ryansurf/cli-surf/issues/114

Poetry was trying to download matplotlib 3.9.1, which was causing issues on windows and the build was failing, for reasons described here

In this fix, poetry uses matplotlib 3.9.0

All tests should pass on this PR, which will mean this works

@K-dash if you can review this that would be awesome!

sourcery-ai[bot] commented 3 months ago

🧙 Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
github-actions[bot] commented 3 months ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   __init__.py00100% 
   api.py119794%32–36, 54, 76–77, 109–110
   art.py9367%32–33, 36
   cli.py250100% 
   dev_streamlit.py37370%1–86
   gpt.py10640%16–21, 32–45
   helper.py1243869%110, 121–125, 201–209, 221, 234–235, 266, 268–269, 292–293, 356–366, 373–381
   send_email.py24240%5–48
   server.py471079%55, 68–71, 87–91, 103–105
   settings.py220100% 
   streamlit_helper.py33330%5–90
TOTAL45015865% 

Tests Skipped Failures Errors Time
11 0 :zzz: 0 :x: 0 :fire: 21.359s :stopwatch:
K-dash commented 3 months ago

@ryansurf Will review tonight!

K-dash commented 3 months ago

@ryansurf That's great! The Windows runner test has also succeeded.:) By the way, it seems that the issue mentioned in https://github.com/matplotlib/matplotlib/issues/28551#issuecomment-2285190039 has been closed, and it appears to have been improved in version 3.9.2. (I think this PR is fine as it is. I'm just sharing this information for your reference.)