Closed ryansurf closed 3 months ago
🧙 Sourcery has finished reviewing your pull request!
Coverage Report
File Stmts Miss Cover Missing src __init__.py 0 0 100% api.py 119 7 94% 32–36, 54, 76–77, 109–110 art.py 9 3 67% 32–33, 36 cli.py 25 0 100% dev_streamlit.py 37 37 0% 1–86 gpt.py 10 6 40% 16–21, 32–45 helper.py 124 38 69% 110, 121–125, 201–209, 221, 234–235, 266, 268–269, 292–293, 356–366, 373–381 send_email.py 24 24 0% 5–48 server.py 47 10 79% 55, 68–71, 87–91, 103–105 settings.py 22 0 100% streamlit_helper.py 33 33 0% 5–90 TOTAL 450 158 65%
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
11 | 0 :zzz: | 0 :x: | 0 :fire: | 21.359s :stopwatch: |
@ryansurf Will review tonight!
@ryansurf That's great! The Windows runner test has also succeeded.:) By the way, it seems that the issue mentioned in https://github.com/matplotlib/matplotlib/issues/28551#issuecomment-2285190039 has been closed, and it appears to have been improved in version 3.9.2. (I think this PR is fine as it is. I'm just sharing this information for your reference.)
https://github.com/ryansurf/cli-surf/issues/114
Poetry was trying to download matplotlib 3.9.1, which was causing issues on windows and the build was failing, for reasons described here
In this fix, poetry uses matplotlib 3.9.0
All tests should pass on this PR, which will mean this works
@K-dash if you can review this that would be awesome!