Closed K-dash closed 4 months ago
@K-dash nice, this looks great! Works on my end, nice tests too. Thank you! Merging now
@ryansurf Thank you for accepting my pull request!
Since we no longer use args=
, the README.md file should need to be updated. Is it necessary for me to make those changes, or do you prefer to handle the README.md update yourself?
Oh, there's also the GIF image that needs to be updated, so it might be better for you to handle it...
No need to change the readme, unless you'd like to. I'll get to it at some point tomorrow, either way works👍
@all-contributors please add @K-dash for code and documentation
@ryansurf
We had trouble processing your request. Please try again later.
@all-contributors please add @K-dash for code
@K-dash
We had trouble processing your request. Please try again later.
@ryansurf
The changes are as follows:
server.py
to use the newquery_to_args_list
function fromhelper.py
instead of theparse_qs
functionquery_to_args_list
function is a simple function that stores a string as a listparse_qs
function converts query parameters into a dictionary format. Since the purpose of this change is to deprecateargs=
and store the single string specified in the query parameters as a list, theparse_qs
function is no longer used.query_to_args_list
functionAlso, I believe that the README.md file needs to be updated to reflect these changes, but before proceeding with that, could you please review the changes and confirm if there are any issues with the current implementation?
Fixes #7