ryansurf / cli-surf

Get surf and ocean data from the command line interface
MIT License
18 stars 29 forks source link

Change: remove `args=` parameter #14

Closed K-dash closed 4 months ago

K-dash commented 4 months ago

@ryansurf

The changes are as follows:

Also, I believe that the README.md file needs to be updated to reflect these changes, but before proceeding with that, could you please review the changes and confirm if there are any issues with the current implementation?

Fixes #7

ryansurf commented 4 months ago

@K-dash nice, this looks great! Works on my end, nice tests too. Thank you! Merging now

K-dash commented 4 months ago

@ryansurf Thank you for accepting my pull request!

Since we no longer use args=, the README.md file should need to be updated. Is it necessary for me to make those changes, or do you prefer to handle the README.md update yourself?

K-dash commented 4 months ago

Oh, there's also the GIF image that needs to be updated, so it might be better for you to handle it...

ryansurf commented 4 months ago

No need to change the readme, unless you'd like to. I'll get to it at some point tomorrow, either way works👍

ryansurf commented 2 months ago

@all-contributors please add @K-dash for code and documentation

allcontributors[bot] commented 2 months ago

@ryansurf

We had trouble processing your request. Please try again later.

K-dash commented 2 months ago

@all-contributors please add @K-dash for code

allcontributors[bot] commented 2 months ago

@K-dash

We had trouble processing your request. Please try again later.