search

ryansurf / cli-surf

Get surf and ocean data from the command line interface
MIT License
16 stars 24 forks source link

Replace Docker base image to reduce # of open-source vulnerabilities #52

Closed Hummus-Ful closed 1 month ago

Hummus-Ful commented 1 month ago

I suggest to replace the Docker base image currently being used by python:alpine one in order to:

  1. Reduce the number of open-source vulnerabilities exists in python:3.12.3-slim base image by using python:alpine3.20 instead.
  2. Reduce the final Docker image size from 549MB to 486MB slim_vs_alpine
ryansurf commented 1 month ago

Hey @Hummus-Ful, welcome! I think that's a solid idea, have you tested to make sure that all dependencies still work with alpine?

If so, let's go for it

Hummus-Ful commented 1 month ago

Hey @ryansurf, Yes, I've tested the API manually and ran both make test and make test_docker and all 9 tests passed successfully.

ryansurf commented 1 month ago

@Hummus-Ful awesome, did you want to submit a PR for this? I can do it too, up to you

Hummus-Ful commented 1 month ago

PR created: #53