search

ryansurf / cli-surf

Get surf and ocean data from the command line interface
MIT License
18 stars 30 forks source link

new colors #78

Closed mrmcgrain closed 3 months ago

mrmcgrain commented 3 months ago

Summary by Sourcery

Introduce new color codes for 'black' and 'cyan' to enhance the color options available in the application.

New Features:

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request adds two new color definitions to the 'src/art.py' file. The colors 'black' and 'cyan' are introduced with their respective escape codes.

File-Level Changes

Files Changes
src/art.py Added two new color definitions: 'black' and 'cyan'.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
mrmcgrain commented 3 months ago

Introduce new color codes for 'black' and 'cyan' to enhance the color options available in the application.

New Features:

Add new color codes for 'black' and 'cyan' to the color dictionary in src/art.py.

ryansurf commented 3 months ago

Hey @mrmcgrain, looks great! Can you add these new colors to help.txt? I'll merge your PR after that is done :+1:

mrmcgrain commented 3 months ago

Just updated the help.txt, Thank you for my first contribution experience.. While I did not do much, the process was very informative.

On Fri, Aug 2, 2024 at 9:03 AM Ryan Frederich @.***> wrote:

Hey @mrmcgrain https://github.com/mrmcgrain, looks great! Can you add these new colors to help.txt https://github.com/ryansurf/cli-surf/blob/main/help.txt? I'll merge your PR after that is done 👍

— Reply to this email directly, view it on GitHub https://github.com/ryansurf/cli-surf/pull/78#issuecomment-2265710610, or unsubscribe https://github.com/notifications/unsubscribe-auth/BESPBXGDWT4FQYSD7LVOLSLZPOUV3AVCNFSM6AAAAABL3QPQNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVG4YTANRRGA . You are receiving this because you were mentioned.Message ID: @.***>

ryansurf commented 3 months ago

@mrmcgrain thank you for your contribution. So, another opportunity to learn just came up 😄

The linter failed! It looks like there's some trailing whitespace in the updated code. You can run make lint and make format to fix these (the formatter will automatically fix it for you).

Let me know if that works

mrmcgrain commented 3 months ago

appears I do not have make on my windows machine...lol, looking into that now

On Fri, Aug 2, 2024 at 9:43 AM Ryan Frederich @.***> wrote:

@mrmcgrain https://github.com/mrmcgrain thank you for your contribution. So, another opportunity to learn just came up 😄

The linter failed https://github.com/ryansurf/cli-surf/actions/runs/10218906115/job/28276136133?pr=78! It looks like there's some trailing whitespace in the updated code. You can run make lint and make format to fix these (the formatter will automatically fix it for you).

Let me know if that works

— Reply to this email directly, view it on GitHub https://github.com/ryansurf/cli-surf/pull/78#issuecomment-2265774348, or unsubscribe https://github.com/notifications/unsubscribe-auth/BESPBXBRJ7WZRPGZY3A5SSLZPOZKJAVCNFSM6AAAAABL3QPQNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVG43TIMZUHA . You are receiving this because you were mentioned.Message ID: @.***>

ryansurf commented 3 months ago

@mrmcgrain whoops, well you shouldn't need it. Checkout the makefile and run the commands under lint & format

Here's the command to format:

poetry run ruff check --fix $(sources) poetry run ruff format $(sources)

Sorry, I'm on my phone so the formatting may be off