search

ryant26 / SparceMatrices

Apache License 2.0
0 stars 0 forks source link

floating point equality tests #3

Open kdbanman opened 9 years ago

kdbanman commented 9 years ago

in isInvertible, determinant is compared directly with zero. there is a very good chance this value will be floating point, so we should define a class EPSILON around 1E-10 for value comparison.

there may be other locations such comparisons are made, hence the issue.

kdbanman commented 9 years ago

if we don't get around to fixing all floating point comparisons, we should reference it in our report.

ryant26 commented 9 years ago

Hadn't considered that, good catch.