ryantam626 / jupyterlab_code_formatter

A JupyterLab plugin to facilitate invocation of code formatters.
MIT License
822 stars 52 forks source link

the jupyterlab extension version is out of sync with the pip package version #308

Closed achimgaedke closed 1 year ago

achimgaedke commented 1 year ago

I can imagine this is "work in progress" - and I fear this is a whack-a-mole task.

Here are my two observations for 2.0 and 2.1-rc0:

$ pip install "jupyterlab_code_formatter==2.0.0"
[...]
Successfully installed jupyterlab_code_formatter-2.0.0
$ jupyter labextension list                     
JupyterLab v3.6.3
/usr/local/Caskroom/miniforge/base/envs/c_format_test/share/jupyter/labextensions
        jupyterlab_pygments v0.2.2 enabled OK (python, jupyterlab_pygments)
        jupyterlab_code_formatter v2.0.0-rc1 enabled OK (python, jupyterlab_code_formatter)
        @jupyter-widgets/jupyterlab-manager v5.0.7 enabled OK (python, jupyterlab_widgets)
$ pip install "jupyterlab_code_formatter==2.1.0rc0"
[...]
Installing collected packages: jupyterlab_code_formatter
Successfully installed jupyterlab_code_formatter-2.1.0rc0
$ jupyter labextension list                        
JupyterLab v3.6.3
/usr/local/Caskroom/miniforge/base/envs/c_format_test/share/jupyter/labextensions
        jupyterlab_pygments v0.2.2 enabled OK (python, jupyterlab_pygments)
        jupyterlab_code_formatter v2.0.0 enabled OK (python, jupyterlab_code_formatter)
        @jupyter-widgets/jupyterlab-manager v5.0.7 enabled OK (python, jupyterlab_widgets)
ryantam626 commented 1 year ago

Are these from a clean venv?

achimgaedke commented 1 year ago

No, fair point... repeating... finding same results... (and yeah, I know this is a tedious task, hoping to be helpful with reporting.)

Executing

python3.11 -m venv jlcf20
./jlcf20/bin/pip install jupyterlab_code_formatter==2.0.0 jupyterlab
./jlcf20/bin/jupyter labextension list

Output:

JupyterLab v3.6.3
/Users/achim/jlcf20/share/jupyter/labextensions
        jupyterlab_pygments v0.2.2 enabled OK (python, jupyterlab_pygments)
        jupyterlab_code_formatter v2.0.0-rc1 enabled OK (python, jupyterlab_code_formatter)

Repeating with 2.1.0rc0:

python3.11 -m venv jlcf21           
./jlcf21/bin/pip install jupyterlab_code_formatter==2.1.0rc0 jupyterlab
./jlcf21/bin/jupyter labextension list

Output:

JupyterLab v3.6.3
/Users/achim/jlcf21/share/jupyter/labextensions
        jupyterlab_pygments v0.2.2 enabled OK (python, jupyterlab_pygments)
        jupyterlab_code_formatter v2.0.0 enabled OK (python, jupyterlab_code_formatter)
ryantam626 commented 1 year ago

hmm very odd. i mucked up my release process somewhere. i will keep an eye out on this next time.

with that said, is the plugin useable?

achimgaedke commented 1 year ago

Yes, absolutely - tested only for 2.0.0 though... also submitted https://github.com/conda-forge/jupyterlab_code_formatter-feedstock/pull/48 - that's where I encountered this issue the first time...

Do you use https://test.pypi.org/ ? - might be helpful for this type of work...

Thanks for providing this extension.

ryantam626 commented 1 year ago

I don't use the test version of pypi at the moment, but that's a really good shout, it never occured to me.

ryantam626 commented 1 year ago

Okay, I figured out what I did wrong now, it should be in sync again! Thanks for the report!