search

ryantenney / log4j-redis-appender

log4j appender writing straight to Redis
Other
33 stars 26 forks source link

com/ryantenney/log4j/RedisAppender.java line 152 is not thread-safe. #7

Closed lendo closed 9 years ago

lendo commented 9 years ago

line 152: while ((event = events.poll()) != null)

is not thread-safe, it may cause a confusion of log data .

My changes are as follows:

synchronized(events) { while ((event = events.poll()) != null) { // do something. } }