Add support for PKBarcodeFormatCode128 and updated test case. - Githubissues

ryantenney / passkit4j

Java library for generating Apple Passbook (.pkpass) files

http://www.ryantenney.com/passkit4j/

Apache License 2.0

80 stars 50 forks source link

Add support for PKBarcodeFormatCode128 and updated test case. #30

Closed Alfons109 closed 9 years ago

Alfons109 commented 9 years ago

Hi Ryan, iOS9 now has support for PKBarcodeFormatCode128. I have made the necessary changes to the library to add this. I have tested this on iOS9/8/7 and it works great.

The change added includes:

new barcode format PKBarcodeFormatCode128
new barcodes key, that is an array that takes in a dictionary of barcodes, which defines the primary barcode and a fallback. You can read more about it here:

https://developer.apple.com/library/prerelease/ios/documentation/UserExperience/Reference/PassKit_Bundle/Chapters/TopLevel.html#//apple_ref/doc/uid/TP40012026-CH2-SW1

Aside:

I did not check-in the pom.xml file, but please be aware that I could not get delombok goal to work so I had comment it out. This what my delombok section of the pom.xml looks like.
```
 <plugin/>
        <groupId>org.projectlombok</groupId>
        <artifactId>lombok-maven-plugin</artifactId>
        <version>1.16.6.1</version>
```
```
  </plugin>
```

ryantenney commented 9 years ago

Thank you!