search

ryantianj / pe

0 stars 0 forks source link

Adding a duplicate contact with an invalid handle returns the wrong command result #6

Open ryantianj opened 3 years ago

ryantianj commented 3 years ago

Adding a duplicate contact with an invalid handle results in the error below: image.png

As a user, i would have expected this error instead:

image.png

nus-pe-bot commented 3 years ago

Team's Response

In this issue, there are two errors that are being parsed for:

  1. erroneous input in Telegram field
  2. duplicate contact

We chose to parse for error 1 before error 2. The same issue would have surfaced if we chose to parse error 2 first before error 1. Hence we reject this bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As mentioned about the two issues, I believe parsing 2 before 1 is different and would result in lesser inconvenience for the user: Based on current implementation, If the user has erroneous inputs in all of the fields, the user has to correct all the errors in the fields one-by-one before the app informs the user that the contact is a duplicate. Parsing 2 before 1, User will be immediately informed that it is a duplicate contact. The correctness of the handle/inputs would not have mattered if it was duplicate.