search

ryantibs / conformal

Tools for conformal inference in regression
GNU General Public License v2.0
214 stars 52 forks source link

Adding jackknife plus #17

Closed paolo-vergo closed 2 years ago

paolo-vergo commented 2 years ago

As requested I introduced Jackknife+ as integration to the original conformal.pred.jack function.

ryantibs commented 2 years ago

By the way, @paolo-vergo: please add yourself (and any others who contributed to this code) as authors in the DESCRIPTION file of this PR!

paolo-vergo commented 2 years ago

@ryantibs I have updated my branch, integrating all the corrections.

ryantibs commented 2 years ago

Thanks! Can you please respond to the comments raised above and resolve the conversations if you think they're resolved? That will help me get a better sense of where things stand.

Also, just to double check: are all the people you listed under authors contribute to the code itself? This is supposed to be a list of authors for the package development (not for the research ideas that support it).

paolo-vergo commented 2 years ago

@ryantibs I should have resolved all the conversations.

As long as the list of people is concerned, they all contributed to the code (even if some were small contributions). Do you think, then, they should also be listed as authors or rather as contributors ? Let me know!

ryantibs commented 2 years ago

Thanks!

Re the authors in the description: whether author "aut" or contributor "ctb", I'll leave it completely up to you (I of course don't know the level of their contributions, since I only see your commits). You can read about the description of these two categories here: https://r-pkgs.org/description.html#description-authors

paolo-vergo commented 2 years ago

Ok! I'll read the description carefully and update it accordingly.

Thanks!

matteo-fontana commented 2 years ago

Dear Ryan, Now the authorship should be fine.

ryantibs commented 2 years ago

Sorry for the delay. I just merged the changes now (after a typo fix and doc rebuild).