search

ryanto / ember-flash-message

Flash message for Ember.JS templates.
49 stars 23 forks source link

Dismissing Flash Messages #14

Closed Emerson closed 10 years ago

Emerson commented 10 years ago

Hey Ryan,

This pull request is an enhancement discussed in issue #9.

I've added a simple action in the FlashMessageController that sets the currentMessage to null. I like the action approach because it provides a nice level of flexibility. This pull request includes:

  1. An updated README
  2. The rebuilt plugin
  3. A test to make sure things work as expected
ryanto commented 10 years ago

Looks good. Merged.

PS: I gave you commit access to this repo, feel fee to add/change anything. You're last few PRs have been great.

Emerson commented 10 years ago

Appreciate this, thanks for the confidence. Gotta love those open source feels.