search

ryanuber / go-license

Software licensing standardization library for Golang
MIT License
69 stars 15 forks source link

case-insenstive comparison: License.txt #8

Closed ahmetb closed 8 years ago

ahmetb commented 8 years ago

I was looking at GuessFile method and it looks like if the license file is

it wouldn't match... (I know, microsoft people, right?..)

Perhaps if we do the string comparison case-insensitive, that could also help eliminating the duplication going on at DefaultLicenseFiles variable.

What do you think @ryanuber ?

ryanuber commented 8 years ago

Makes sense to me! I agree it would be nicer to just strings.ToLower() everything before comparing.

client9 commented 8 years ago

I'm going to work on a pull request for this one, minus objections.

client9 commented 8 years ago

see #9 pull request

client9 commented 8 years ago

Ok @ryanuber should be good to take a look in #9 thx to @ahmetalpbalkan I added some more testing.

client9 commented 8 years ago

This can be closed