search

ryanvade / flysystem-box

Flysystem Box.com Adapter
MIT License
3 stars 4 forks source link

Changes to listContents #4

Closed paulm17 closed 6 years ago

paulm17 commented 6 years ago

In the current state, the library doesn't work. The following changes ensures that results for listContents works.

ryanvade commented 6 years ago

The last time I used this code it was working well enough. What conditions require the proposed changes?

paulm17 commented 6 years ago

When did you last use this code? As I freshly installed the two libs you created, the end result was non-functioning code.

There are 3 errors that I had to resolve.

First is the mistype of path and directory. Then there is another function I can't remember that complains that ['path'] is missing. Finally, when the path issue is resolved, there is data missing that comes from box, and flysystem complains that some attributes are missing. Hence the PR for laravelBox to return the correct data.

Without these 3 fixes. The code simply doesn't work.

ryanvade commented 6 years ago

It was about a year ago, I designed this for Laravel 5.2 so perhaps some things changed between then and now.

paulm17 commented 6 years ago

Oh for sure! Probably dozens of changes from .2 to .6.

Also, the code was inspired from the dropbox adapter. Might as well use what works.

ryanvade commented 6 years ago

Agreed. Thanks for the PR.