search

ryanve / response.js

Responsive design toolkit
http://responsejs.com
Other
801 stars 123 forks source link

consistency in the API #4

Closed ryanve closed 12 years ago

ryanve commented 12 years ago

In February (version 0.3.0) I added the dimensions to the main API. They're all methods (function calls) with the exception of deviceW, deviceH, deviceMax, and deviceMin properties (all 4 are integers). In retrospect, for consistency, I think I should have made those methods rather than properties (so they would require parens like the others). Since these were recent additions, I'm leaning towards making this change in version 0.5.0. In which case anyone who had used those 4 props in their code would have to update them to include parens. This probably would only affect a few people. I'd rather straighten this out now then wish I did down the line. Does that make sense?

anointed commented 12 years ago

makes perfect sense. I was just coming back to this code as I had a project which needed it. I have no problem waiting for the next vs. should make it easier to follow in the long run.

ryanve commented 12 years ago

@anointed Cool / thanks. I'm hoping to roll out the next version this week.

ryanve commented 12 years ago

Done deal—changed all four into methods in version 0.5.0