search

ryanvolum / offline-directline

Unofficial package to emulate the bot framework connector locally.
https://www.npmjs.com/package/offline-directline
78 stars 44 forks source link

Get Conversation ID from URL #17

Closed howlowck closed 6 years ago

howlowck commented 6 years ago

Issue:

When doing a post to send a message to the bot, the conversation ID is not set properly. The conversation ID is set using a global scope, instead from the URL.

https://github.com/ryanvolum/offline_dl/blob/master/src/bridge.ts#L72

Proposal:

Add an optional conversationId parameter in createMessageActivity signature. If it's not defined, it defaults to the global variable.

https://github.com/ryanvolum/offline_dl/blob/master/src/bridge.ts#L216

I can make a PR if this sounds good.

ryanvolum commented 6 years ago

Hey Hao - this sounds good - feel free to make the PR!

howlowck commented 6 years ago

Awesome! PR submitted 😄