search

ryanvolum / offline-directline

Unofficial package to emulate the bot framework connector locally.
https://www.npmjs.com/package/offline-directline
79 stars 44 forks source link

removed redundant port/endpoint params on initializeRoutes/cmd utility #35

Closed ryanvolum closed 6 years ago

ryanvolum commented 6 years ago

Previously, the initializeRoutes function took both an endpoint to host offline-directline and a port to host it on. This led to redundant code, and presented issues for the command line utility introduced in the last version.

This PR removes the serviceUrl param on initializeRoutes and replaces it with the port representing the port on localhost you wish to host directline on. This PR also makes appropriate changes to the README/package version and fixes some linting issues.