search

ryanvolum / offline-directline

Unofficial package to emulate the bot framework connector locally.
https://www.npmjs.com/package/offline-directline
78 stars 44 forks source link

CORS header allow x-ms-bot-agent #37

Closed AGeekDad closed 5 years ago

AGeekDad commented 5 years ago

Getting error: CORS policy: Request header field x-ms-bot-agent is not allowed by Access-Control-Allow-Headers in preflight response.

directline.js is now sending x-ms-bot-agent in commonHeaders method: https://github.com/Microsoft/BotFramework-DirectLineJS/blob/master/src/directLine.ts

Need to add this header to Access-Control-Allow-Headers: res.header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept, Authorization, x-ms-bot-agent');

schemburkar commented 5 years ago

i too am seeing this exact issue. Can we get this merged sooner?

ryanvolum commented 5 years ago

Apologies @schemburkar and @AGeekDad - I haven't been monitoring this repo. I'll take a look at the PR today and cut a new package if it looks good! Thanks for the contribution!

ryanvolum commented 5 years ago

This has been resolved with #38