ryanvolz / radioconda

Software radio distribution and installer for conda
Other
342 stars 39 forks source link

Missing object attribute in gfsk.py #49

Closed Gemikro1 closed 1 year ago

Gemikro1 commented 1 year ago

Using the GFSK Demod block throws an error in the function def _print_verbage(self): because the attribute _mu is missing. This attribute seems to have been deprecated but is still used in the function:

    def _print_verbage(self):
        print("bits per symbol = %d" % self.bits_per_symbol())
        print("Symbol Sync M&M omega = %f" % self._omega)
        print("Symbol Sync M&M gain mu = %f" % self._gain_mu)
        print("M&M clock recovery mu (Unused) = %f" % self._mu)
        print("Symbol Sync M&M omega rel. limit = %f" %
              self._omega_relative_limit)
        print("frequency error = %f" % self._freq_error)

Removing line 273 print("M&M clock recovery mu (Unused) = %f" % self._mu) fixes the error ...

ryanvolz commented 1 year ago

This appears to be a bug with current GNU Radio. I guess not many people have been using that block. I'll suggest that you report this upstream to see how it can be handled properly.

Gemikro1 commented 1 year ago

Agreed, i will report it there. I found that this happens anyway only when verbose output is enabled.

ryanvolz commented 1 year ago

Fixed by https://github.com/gnuradio/gnuradio/pull/6518, in the gnuradio 3.10.6.0 release.

Gemikro1 commented 1 year ago

Perfect, thanks. Will try next time.