Closed ryanw-mobile closed 2 weeks ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: -0.03% (target: -1.00%) | :white_check_mark: 56.04% |
:rocket: Don’t miss a bit, follow what’s new on Codacy.
Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more
Attention: Patch coverage is 55.68182%
with 39 lines
in your changes missing coverage. Please review.
Project coverage is 50.48%. Comparing base (
4da6a3e
) to head (c4395d3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently we always split data range into two variables as we directly mapped the api response to models, we used to allow end date to be null, as the api uses that to represent "no end date"
This refactoring simply combines them into a range of Instants, and we use Instant.DISTANT_FUTURE to represent "no end date". In this way we eliminated many null handling.