Closed ryanw-mobile closed 3 months ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: -0.03% (target: -1.00%) | :white_check_mark: 14.29% |
:rocket: Don’t miss a bit, follow what’s new on Codacy.
Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more
Attention: Patch coverage is 11.62791%
with 38 lines
in your changes missing coverage. Please review.
Project coverage is 49.53%. Comparing base (
cadb3c3
) to head (7a678cd
).:exclamation: Current head 7a678cd differs from pull request most recent head 84ae628
Please upload reports for the commit 84ae628 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The API returns up to 100 records per request Right now we are not using anything up to that page limit, but to facilitate future tickets, we improved the repository to accept either requesting a particular page number, or to automatically retrieve the entire data set, by having the repository to automatically loop through the requests until the backend says there is no more next page.
Although not related, added some repository unit tests as a starting point. This is not done now because the upcoming tickets will incorporate database caching which we are going to change the repository behaviour quite a lot.
The loading screen also updated, so that the animated icon now becomes smaller.