ryanw-mobile / OctoMeter

🔥Kotlin Multiplatform Desktop/Android/iOS Energy Tracker app
Other
126 stars 10 forks source link

(#252) Fix Agile chart max y-axis range to consider flexible and fixed unit rates #253

Closed ryanw-mobile closed 3 months ago

ryanw-mobile commented 3 months ago

When the Agile max rate in sight is still cheaper than the available flexible and fixed unit rates, we have changed to consider both rates when calculating the max range for the chart, so that proportionally, the Agile max will not be the range max, and it will relatively be shown using "greener" colours.

This reflects that since the most expensive Agile unit rate is still cheaper than the flexible and fixed tariffs, it should be considered "cheaper", not the "most expensive", even hitting the agile max in the range.

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.22% (target: -1.00%) :white_check_mark: 0.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (4aebefcf6ac8a661bd89a99f1d8a4fc979d0cf59) | 2129 | 1398 | 65.66% | | | Head commit (1ee0028c8aae2cb4f57e3d3576a0c59e449e2d8c) | 2136 (+7) | 1398 (+0) | 65.45% (**-0.22%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#253) | 8 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more