ryanwholey / terraform-provider-pihole

A Terraform provider for managing Pi-hole resources
https://registry.terraform.io/providers/ryanwholey/pihole/latest/docs
Mozilla Public License 2.0
63 stars 8 forks source link

Remove update DNS functions #32

Closed ryanwholey closed 2 years ago

ryanwholey commented 2 years ago

Removes the "update" functions for CNAME and A records. The Pi-hole API does not formally support updates, just list, create, delete. Update was implemented here by combining create and delete, which is not atomic but would be assumed to be so if you didn't inspect the code. Instead of creating/deleting under the hood which wasn't a great idea in the first place, we can have Terraform do this for us by forcing replacement on cname.target and dns.ip. This way the implications of the proposed changes are clearly stated by the Terraform plan, instead of hiding the behavior behind a function.