search

ryapric / loggit

Modern Logging for the R Ecosystem
Other
37 stars 2 forks source link

Implement automatic log rotation #21

Open psolymos opened 2 years ago

psolymos commented 2 years ago

This PR addresses #20 and fixes an issue when nrow(log_df) - rotate_lines + 1 leads to negative row index.

ryapric commented 2 years ago

Thank you, looks pretty good! Could you also add some tests to confirm functionality?

psolymos commented 2 years ago

@ryapric I addressed the comments. Let me know what you think.