search

ryardley / ts-bus

A lightweight JavaScript/TypeScript event bus to help manage your application architecture.
MIT License
135 stars 8 forks source link

Undefined event payloads #25

Closed ryardley closed 5 years ago

ryardley commented 5 years ago

This is in response to https://github.com/ryardley/ts-bus/pull/24

This allows for events to be dispatched without payloads..

codecov[bot] commented 5 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          56     55    -1     
  Branches       11     11           
=====================================
- Hits           56     55    -1
Impacted Files Coverage Δ
src/EventBus.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23de6fb...959493c. Read the comment docs.

dmicic commented 5 years ago

Nice one. It's great having only one createEventDefinition function. Definitely reduces confusion when you create your first 'payload-less' event. Feels more logical not to pass a parameter if you don't define the generic type.