search

rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

added detekt #111

Open UDarya opened 5 years ago

gokulchandra commented 5 years ago

@rybalkinsd Do we require a static code analyser?

rybalkinsd commented 5 years ago

@UDarya many thanks for the proposal!

@gokulchandra I will check it right after 0.10.0 release. However, you're welcome to give suggestions/resolution about it.

We're using Codacy at the moment for static analysis, but probably direct use of detekt would be a better choice.

gokulchandra commented 5 years ago

I think it might be a good idea to add it to the project and make it a part of the build process.

@rybalkinsd Have you faced any issues with codacy as of yet? Do you see any pain points in Codacy that detekt could help with?

rybalkinsd commented 5 years ago

@UDarya @gokulchandra detekt 1.0 is out. would you mind to update PR?

BoxResin commented 5 years ago

@UDarya You have to resolve conflicts too!