rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

Dependency on Jackson even tho it is only used in one extension method #115

Closed dtropanets closed 5 years ago

dtropanets commented 5 years ago

Hey. I've noticed that there is a dependency on Jackson. Is it really that necessary to add it to the library just to use it inside of one extension method? Can it be possibly moved to a separate artifact?

rybalkinsd commented 5 years ago

@dtropanets that's a good point. I was also thinking about it some times ago. Are you satisfied with the default configuration of defaultHttpClient?

Just in case, did you get any Jackson version conflicts while using?

Potentially, it's possible to move default client configuration feature to the separate artifact.

rybalkinsd commented 5 years ago

As for the current vision:

rybalkinsd commented 5 years ago

@dtropanets do you have any further suggestions according to the vision

rybalkinsd commented 5 years ago

@gokulchandra You previously get in touch with json within the project. Would you be interested in PoC design for this feature?

dtropanets commented 5 years ago

@rybalkinsd We had to use custom client in order to use proxy, so can't tell much about the default one. Regarding the Jackson, I excluded all Jackson modules from dependency after we've noticed that it is included in 0.9.0. Don't remember having any issues. Also, can't tell much about yaml config, since I won't be able to use it, since I have to dynamically build the client in order to apply the proxy values received from the build machine (we use kohttp exclusively for CI scripts).

rybalkinsd commented 5 years ago

Closing this issue due to #128 plan

rybalkinsd commented 5 years ago

@dtropanets Thanks for the details!