search

rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

Move to assertj + junit 5 #122

Closed rybalkinsd closed 4 years ago

vpondala commented 4 years ago

I can help with this.

rybalkinsd commented 4 years ago

@vpondala that would be amazing!

vpondala commented 4 years ago

@rybalkinsd Please let me know if you know why the build is failing now: https://travis-ci.org/rybalkinsd/kohttp/builds/593529245. I am getting this error "java.lang.NoClassDefFoundError: Could not initialize class io.mockk.impl.JvmMockKGateway" on my local, and I am sure that's unrelated to my AssertJ changes.

rybalkinsd commented 4 years ago

@vpondala Let me check

rybalkinsd commented 4 years ago

@vpondala please check https://travis-ci.org/rybalkinsd/kohttp/builds/593529245 Failing test is an integration test with postman-echo. So probably a service issue. It'll be great to move more and more tests from being integration to unit + mocks in the near future.

created #165 as following general improvement

samokisha commented 4 years ago

@rybalkinsd, is this issue done?

rybalkinsd commented 4 years ago

Hey @samokisha ! I thinks yes, it's done.