rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

Migrate to AssertJ for assertions (#122) #163

Closed vpondala closed 4 years ago

vpondala commented 4 years ago

Converted most of the assertions to AssertJ assertions.

vpondala commented 4 years ago

The value %20 is causing issue with comparision of strings due to this: http://joel-costigliola.github.io/assertj/core-8/api/org/assertj/core/api/AbstractStringAssert.html#isEqualTo-java.lang.String-java.lang.Object...-

Let me find if something can be done to avoid this issue.

codecov[bot] commented 4 years ago

Codecov Report

Merging #163 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     90.47%   90.47%           
  Complexity      128      128           
=========================================
  Files            42       42           
  Lines           399      399           
  Branches         45       45           
=========================================
  Hits            361      361           
  Misses           14       14           
  Partials         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 123ca56...2ad91b1. Read the comment docs.

rybalkinsd commented 4 years ago

@gokulchandra would you mind to review this?

rybalkinsd commented 4 years ago

Thanks @vpondala ! Just merge it and change seems perfect