search

rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

[WIP] - Spring boot starter #166

Closed gokulchandra closed 4 years ago

gokulchandra commented 4 years ago

Started off with a basic spring boot project for #127

codecov[bot] commented 4 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     90.47%   90.47%           
  Complexity      128      128           
=========================================
  Files            42       42           
  Lines           399      399           
  Branches         45       45           
=========================================
  Hits            361      361           
  Misses           14       14           
  Partials         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update efe3dda...6e7002c. Read the comment docs.

rybalkinsd commented 4 years ago

I suggest you could create a task for springboot sample, we merge the sample and then iteratively come to our new starter.

How it sounds for you @gokulchandra ?

gokulchandra commented 4 years ago

@gokulchandra I really like how it goes!

it's a good sample for spring.

There are several things I want to mention:

* we can merge this after a couple of minor fixes

* as for proper integration with spring boot we need to create a separate artifact `kohttp-spring`
  we should enable a way to configure our http client using spring beans like
@Bean 
fun defaultHttpClient() = ...

Here is an intro for SB starter https://www.baeldung.com/spring-boot-starters

Ah, yeah that would be a great addition. I initially assumed its about providing a Spring-boot sample. My Bad!

As you suggested let me create a task for this and merge it. l can start working on the spring-starter. πŸ‘

rybalkinsd commented 4 years ago

As you suggested let me create a task for this and merge it. l can start working on the spring-starter. πŸ‘

Yeah, very welcome to start with this issue. I'm also doing some experiments with this integration at the moment. So if you would like to push any code - it's better to create branch inside the origin repo, to be able to edit it together.