rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

Added unit tests #193

Closed Hakky54 closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #193 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage     91.28%   91.28%           
  Complexity      127      127           
=========================================
  Files            44       44           
  Lines           413      413           
  Branches         52       52           
=========================================
  Hits            377      377           
  Misses            9        9           
  Partials         27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86275dd...89283e0. Read the comment docs.

Hakky54 commented 4 years ago

By the way I initially thought that these unit tests aren't present so I added it. But then I discovered a different package which also has similar unit tests. Any idea why this is the case?

For example the HttpDeleteAsyncDslTest:

rybalkinsd commented 4 years ago

Any idea why this is the case?

:kohttp-test depends on both :kohttp an :kohttp-jackson and any other module we will introduce in the future.

.asJson function from :kohttp-jackson simplifies tests.

Hakky54 commented 4 years ago

Ah okay, that makes sense