search

rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

WIP: moshi integration #197

Open rybalkinsd opened 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #197 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage     91.28%   91.28%           
  Complexity      127      127           
=========================================
  Files            44       44           
  Lines           413      413           
  Branches         52       52           
=========================================
  Hits            377      377           
  Misses            9        9           
  Partials         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 518abf0...3402765. Read the comment docs.

GolovPavel commented 4 years ago

Hi! Can you explain why did you integrate moshi in the project? I discovered that toType function already exists in kohttp-jackson gradle project, but uses jackson under the hood. What the reasons to use moshi instead of jackson?

rybalkinsd commented 4 years ago

Hi! Can you explain why you integrate moshi in the project? I discovered that toType function already exists in kohttp-test gradle project, but uses jackson under the hood. What the reasons to use moshi instead of jackson?

Hey! Different projects use different (de)serialisation libraries and techniques, Moshi and Jackson are just two possible implementations. We don't want to limit our users with just one. Moshi uses codegen-based approach for deserialisation and it's a preferable way for Android. However, Jackson is reflection based.