search

rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
478 stars 42 forks source link

Bump kohttp version to work with latest Android #203

Open christian-draeger opened 3 years ago

christian-draeger commented 3 years ago

The currently used kohttp version is 3.14.2 which is not working with Android level 30+

According to this stackoverflow question bumping okhttp to version 4.9.0 should fix the problem

rybalkinsd commented 3 years ago

hi, we hope to move to the latest versions really soon.

rybalkinsd commented 3 years ago

Note: update together with Kotlin 1.4.20

rybalkinsd commented 3 years ago

Hey @christian-draeger check out build on master after PR #205. Let me know if it solved the problem and I will release a formal version

rybalkinsd commented 3 years ago

Note: Now koHttp works with Android 4+, need to fill in docs to clarify it

christian-draeger commented 3 years ago

Works thx 👌

gdude2002 commented 3 years ago

Is a release with this fix planned any time soon? The latest release was in May of last year, and okhttp 3.14.2 has issues with non-daemon threads being used for HTTP/2 not being stopped when the application has finished, which prevents it from closing.

I did attempt to disable HTTP/2 by providing a list of protocols to the client, as mentioned in this thread from 2018, but that doesn't seem to help when working with kohttp.

What's waiting for the next release of kohttp?