search

rybalkinsd / kohttp

Kotlin DSL http client
https://kohttp.gitbook.io
Apache License 2.0
479 stars 42 forks source link

compile is deprecated #78

Closed pboschma closed 5 years ago

pboschma commented 5 years ago

Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.

The configuration for Gradle throws this. The Documentation is unclear on how to install it and where to add the lines in the build.gradle file.

BoxResin commented 5 years ago

Replace compile to implementation. I think the README should be updated.

rybalkinsd commented 5 years ago

Yeah, you’re absolutely right. Inside gradle build we already moved to newer declarations: api/implementation. Now thanks to your PR our docs at up to date

pboschma commented 5 years ago

Maybe I am just doing this wrong, but the new installation returns the following error.

Cannot set the value of read-only property 'name' for project ':app' of type org.gradle.api.Project.

rybalkinsd commented 5 years ago

@pboschma I can have a look. Could you please provide a link to your project with this problem?

rybalkinsd commented 5 years ago

Feel free to reopen if problem was not fixed