search

ryboe / CSS3

The most complete CSS support for Sublime Text
MIT License
189 stars 28 forks source link

Completions regression? #198

Closed argyleink closed 3 months ago

argyleink commented 1 year ago

Anyone have completions working that can share with us your dev env?

argyleink commented 1 year ago

this may be an oldie https://github.com/ryboe/CSS3/issues/27#issuecomment-99142496

Luuk-van-Aggelen commented 3 months ago

Hi. You've merged this issue with issue #216 and closed that. But if I may be so free, I don't think these tasks are related.

vrugtehagel commented 3 months ago

@Luuk-van-Aggelen this issue is, I suppose, just vaguely saying "completions are not working" so there's no much of a point having two issues open that both say that.

@argyleink I actually can't reproduce this - I don't use autocomplete normally (I've got "auto_complete": false, in my settings) but commenting that setting out seems to show completions just fine.

Screen Recording 2024-06-10 at 22 14 41

Of course, that doesn't mean the problem doesn't exist; it just means that the regression (if it is one) is a bit more nuanced.

@Luuk-van-Aggelen (or anyone else having the issue) would you mind sharing a bit more details about your setup? What OS are you on? Do you have global or syntax-specific settings that could contribute to this problem? Does it still not provide completions for you with all other packages disabled? I'd be happy to look into the issue, but unfortunately can't do much if I don't have the issue myself.

kubiqsk commented 3 months ago

isn't it because of this?

image

vrugtehagel commented 3 months ago

Thanks @kubiqsk, that's very helpful! It's a bit odd that it's complaining about grey (and not gray), but I recently removed the gray() function so this definitely looks like that would be the regression. I think I might've just missed a reference or two; I've opened a PR to remove these as well. @argyleink could you have a look at https://github.com/ryboe/CSS3/pull/220 and see if that resolves the issue?

kubiqsk commented 3 months ago

Actually, now when you've mentioned it @vrugtehagel , I remember trying to fix that quickly because I thought it was just a typo, so originally it was supposed to be gray and this is just my quick hotfix attempt that didn't work and I just left it like that... But the error is the same anyway.

vrugtehagel commented 3 months ago

Cool! Then I reckon the PR should fix it - let's allow @argyleink some time to review this thread and the pull request, and then we should be back to working completions 😄