Closed bretjb closed 2 years ago
Thanks for taking the time to make a pull request! This looks like a good change, and I appreciate you creating tests (something which the project is in dire need of). The dice function is not actually original code (save for changing it to typescript); you might like to also make a pull request in the original repo!
Kind of late to the party, but just want to say this looks excellent.
What does this do?
TypeException
more placesHow was this tested? Did you test the changes in the compiled
.html
file?Unit tests included; should be no user-visible changes.
Is there a GitHub Issue that this is resolving?
There is not. The background is that I was curious as to how content was generated, and I poked around in the repo and saw some things that could use cleaning up, so I did. Apologies if this has too many unrelated changes in it -- I can certainly back some of them out.