Refactor fetch profession chance - Githubissues

ryceg / Eigengrau-s-Essential-Establishment-Generator

A town generator that is suitable for out of the box play in any fantasy TTRPG setting.

https://eigengrausgenerator.com

MIT License

822 stars 151 forks source link

Refactor fetch profession chance #702

Closed bretjb closed 2 years ago

bretjb commented 2 years ago

What does this do?

Refactor fetchProfessionChance and adding unit tests

Extracting filtering work into separate methods
Moving some math-y stuff to separate file and adding unit tests

How was this tested? Did you test the changes in the compiled `.html` file?

Unit tests + poking around the NPC list in the compiled file

Is there a GitHub Issue that this is resolving?

As I mentioned in Discord, I'm working my way to fixing https://github.com/ryceg/Eigengrau-s-Essential-Establishment-Generator/issues/263 - but I'm finding lots of places to clean up along the way. This is one of them.