ryceg / Eigengrau-s-Essential-Establishment-Generator

A town generator that is suitable for out of the box play in any fantasy TTRPG setting.
https://eigengrausgenerator.com
MIT License
821 stars 150 forks source link

Fix-Typescript-Issues #710

Closed ryceg closed 2 years ago

ryceg commented 2 years ago

What does this do?

Fixes the typing issues that I introduced by pulling to main without making any of the requisite checks. Also extracts several huge files into slightly smaller ones to improve the code smell slightly. Additionally, also fixes an error introduced with the ??= assignment that I didn't catch. Also reduces the number of circular dependencies logged in the compiler (though they're still kinda there).

How was this tested? Did you test the changes in the compiled .html file?

Tested in html by restarting multiple times.

Is there a GitHub Issue that this is resolving?

No.

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 6c8b51a9d29f63e267bf9b54b7001274590fb573 into 5b29ec66cf2f1b3ef1414409d083bf797726b67d - view on LGTM.com

fixed alerts: